Confusables data for Devanagari UE and UUE #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The changes look good to me, but I'm wondering if it's too late for 17.0 data changes and we should keep these for 18.0, or it's fine landing it now. @markusicu? @PeterConstable? |
markusicu
previously requested changes
Aug 11, 2025
Member
markusicu
left a comment
markusicu
left a comment
There was a problem hiding this comment.
As discussed in the PAG meeting last week for Unicode 17:
We should not make any further data changes.
Collaborator
Author
|
Sorry I meant to have this be a draft PR, not for 17.0 |
roozbehp
previously approved these changes
Oct 8, 2025
Contributor
roozbehp
left a comment
roozbehp
left a comment
There was a problem hiding this comment.
LGTM, but needs re-cranking and rebasing.
josh-hadley
force-pushed
the
jh-deva-confusables-ue-uue
branch
2 times, most recently
from
c8c5a2c to
06d715e
Compare
josh-hadley
force-pushed
the
jh-deva-confusables-ue-uue
branch
from
06d715e to
100904c
Compare
Collaborator
Author
|
@roozbehp @markusicu I rebased and re-generated, PTAL |
roozbehp
approved these changes
Oct 9, 2025
Contributor
roozbehp
left a comment
roozbehp
left a comment
There was a problem hiding this comment.
LGTM. We need to find a way to reduce the diff size going forward!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devanagari UE and UUE (PAG ref https://github.com/unicode-org/properties/issues/449)